swamirishi commented on code in PR #7862:
URL: https://github.com/apache/ozone/pull/7862#discussion_r1965967818
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java:
##########
@@ -554,6 +564,11 @@ private CompletableFuture<Message> writeStateMachineData(
CompletableFuture<ContainerCommandResponseProto> writeChunkFuture =
CompletableFuture.supplyAsync(() -> {
try {
+ try {
+ checkContainerHealthy(write.getBlockID().getContainerID());
+ } catch (StorageContainerException e) {
+ return ContainerUtils.logAndReturnError(LOG, e, requestProto);
Review Comment:
We should not fail. If we throw exception then the transactions to other
containers won't get applied as commit index wouldn't increase. On exception
throw we will fail all the transactions in future this would mean even close
container will not make it. The only thing we are preventing here is failing
writes prematurly preventing orphan block chunk writes. There should be no
implication because of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
