rakeshadr commented on a change in pull request #2118:
URL: https://github.com/apache/ozone/pull/2118#discussion_r607974762
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java
##########
@@ -246,13 +246,13 @@ private OMConfigKeys() {
public static final long OZONE_FS_TRASH_CHECKPOINT_INTERVAL_DEFAULT = 0;
// TODO: Temporary workaround for OM upgrade path and will be replaced once
- // upgrade HDDS-3698 story reaches consensus. Defaulting to 'V0' so that
- // existing unit test cases won't be affected. New OM version should be
'V1'.
- public static final String OZONE_OM_LAYOUT_VERSION =
- "ozone.om.layout.version";
- public static final String OZONE_OM_LAYOUT_VERSION_DEFAULT = "V0";
+ // upgrade HDDS-3698 story reaches consensus. Defaulting to 'legacy' so that
+ // existing unit test cases won't be affected. New OM version should be
'prefix'.
+ public static final String OZONE_OM_METADATA_LAYOUT =
+ "ozone.om.metadata.layout";
+ public static final String OZONE_OM_METADATA_LAYOUT_DEFAULT = "legacy";
Review comment:
Please use capital letters.
"LEGACY"
"PREFIX"
##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -2522,12 +2522,12 @@
</property>
<property>
- <name>ozone.om.layout.version</name>
+ <name>ozone.om.metadata.layout</name>
<tag>OZONE, OM</tag>
- <value>V0</value>
+ <value>legacy</value>
<description>Temporary workaround for OM upgrade and will be replaced once
Review comment:
Please modify description to something like below. Please feel free to
edit, if anything needed.
```
<property>
<name>ozone.om.metadata.layout</name>
<tag>OZONE, OM</tag>
<value>LEGACY</value>
<description>
This property is used to define the metadata layout of file system
paths. If it is configured as PREFIX in combination with
ozone.om.enable.filesystem.paths to true then this allows to perform
atomic rename and delete of any directory at any level in the
namespace.
Defaulting to LEGACY. Supported values: LEGACY and PREFIX.
</description>
</property>
```
Can we use the value part in capital letters : LEGACY and PREFIX.
In code, the value can be case insensitive and not required to add strict
validations.
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java
##########
@@ -246,13 +246,13 @@ private OMConfigKeys() {
public static final long OZONE_FS_TRASH_CHECKPOINT_INTERVAL_DEFAULT = 0;
// TODO: Temporary workaround for OM upgrade path and will be replaced once
Review comment:
Please remove this comment. Probably, you can use the same from my above
comment.
```
// TODO: Temporary workaround for OM upgrade path and will be replaced once
// upgrade HDDS-3698 story reaches consensus. Defaulting to 'legacy' so
that
// existing unit test cases won't be affected. New OM version should be
'prefix'.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
