Tejaskriya commented on PR #7813: URL: https://github.com/apache/ozone/pull/7813#issuecomment-2677454518
@ashishkumar50 Thanks for the review. > OpenKeyDeletion: KeysDeleted and KeysCleaned, do we need two dashboards here? what is the difference? `numOpenKeysDeleted` is a metric maintained in `OMOpenKeysDeleteRequest`. It is counting the number of keys being moved from openKeyTable to the deletedTable. `NumOpenKeysCleaned` is a metric maintained in OpenKeyCleanupService, it is counting the actual non hsync keys being deleted. (for hsync keys `NumOpenKeysHSyncCleaned` is the metric). I think both will be helpful in tracking the progress. > DataNode graph, Y-axis is wrong in "No of bytes successfully deleted". > SCM graph, Y-axis names are missing in "No of deletion transactions created" , "No of failed deletion transactions". I have fixed the above 2 comments in the latest commit. Could you please review it again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
