adoroszlai commented on code in PR #7861: URL: https://github.com/apache/ozone/pull/7861#discussion_r1967177141
########## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis_snapshot/OmRatisSnapshotProvider.java: ########## @@ -22,6 +22,7 @@ import java.io.File; import java.io.IOException; import java.io.InputStream; +import java.io.FileOutputStream; import java.net.HttpURLConnection; Review Comment: I guess it depends on the kind of changes done on `master` in the meantime. With new checkstyle rules it can get broken in one commit. Sorry I didn't notice that this PR would fail despite having no conflicts. If in doubt, check out the PR locally, merge `master` into it, then run some quick sanity checks: ```bash gh pr checkout 7861 git merge --no-commit origin/master mvn -DskipTests -DskipRecon -DskipShade clean verify ./hadoop-ozone/dev-support/checks/checkstyle.sh ./hadoop-ozone/dev-support/checks/pmd.sh ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
