peterxcli commented on code in PR #7958:
URL: https://github.com/apache/ozone/pull/7958#discussion_r1967298802


##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/ozoneimpl/TestBackgroundContainerDataScanner.java:
##########
@@ -203,7 +202,8 @@ public void testWithVolumeFailure() throws Exception {
     GenericTestUtils.waitFor(() -> !scanner.isAlive(), 1000, 5000);
 
     // Volume health should have been checked.
-    verify(vol, atLeastOnce()).isFailed();
+    // TODO: remove the mock return value asseration after we upgrade to 
spotbugs 4.8 up
+    assertFalse(verify(vol, atLeastOnce()).isFailed());

Review Comment:
   https://github.com/spotbugs/spotbugs/pull/2550



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to