adoroszlai commented on code in PR #7956:
URL: https://github.com/apache/ozone/pull/7956#discussion_r1967975895
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/replication/TestReplicationManagerScenarios.java:
##########
@@ -498,38 +498,22 @@ public static class Expectation {
private int underReplicatedQueue = 0;
private int overReplicatedQueue = 0;
- private void setUnderReplicated(int underReplicated) {
+ public void setUnderReplicated(int underReplicated) {
stateCounts.put(ReplicationManagerReport.HealthState.UNDER_REPLICATED,
underReplicated);
}
- private void setOverReplicated(int overReplicated) {
+ public void setOverReplicated(int overReplicated) {
stateCounts.put(ReplicationManagerReport.HealthState.OVER_REPLICATED,
overReplicated);
}
- private void setMisReplicated(int misReplicated) {
- stateCounts.put(ReplicationManagerReport.HealthState.MIS_REPLICATED,
misReplicated);
- }
-
- private void setUnhealthy(int unhealthy) {
+ public void setUnhealthy(int unhealthy) {
stateCounts.put(ReplicationManagerReport.HealthState.UNHEALTHY,
unhealthy);
}
- private void setMissing(int missing) {
- stateCounts.put(ReplicationManagerReport.HealthState.MISSING, missing);
- }
-
- private void setEmpty(int empty) {
- stateCounts.put(ReplicationManagerReport.HealthState.EMPTY, empty);
- }
-
- private void setQuasiClosedStuck(int quasiClosedStuck) {
+ public void setQuasiClosedStuck(int quasiClosedStuck) {
stateCounts.put(ReplicationManagerReport.HealthState.QUASI_CLOSED_STUCK,
quasiClosedStuck);
}
- private void setOpenUnhealthy(int openUnhealthy) {
- stateCounts.put(ReplicationManagerReport.HealthState.OPEN_UNHEALTHY,
openUnhealthy);
- }
Review Comment:
I think we should keep these as `public` (if needed) for completeness.
@sodonnel has been adding test cases for this in
`hadoop-hdds/server-scm/src/test/resources/replicationManagerTests`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
