adoroszlai commented on PR #7962: URL: https://github.com/apache/ozone/pull/7962#issuecomment-2680526596
Thanks @devmadhuu for the review. > why are we excluding `org.hadoop.ozone.recon.codegen` package from coverage ? I mean this package does not contain generated code, its the code which is related to schema definition and , some util classes etc. `JooqCodeGenerator` and `TableNamingStrategy` are used at build time. Coverage is calculated based on class usage at runtime. So coverage for these classes is 0%. You are right that some other code is used at runtime (`SqlDbUtils`, `ReconSchemaGenerationModule`, `ReconSqlDbConfig`). I'll move those out of the `...codegen` package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
