kerneltime commented on code in PR #7882:
URL: https://github.com/apache/ozone/pull/7882#discussion_r1970530502
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/AbstractContainerReportHandler.java:
##########
@@ -305,8 +302,14 @@ private boolean updateContainerState(final DatanodeDetails
datanode,
}
}
+ if (!verifyBcsId(replica.getBlockCommitSequenceId(),
container.getSequenceId(), datanode, containerId)) {
+ logger.warn("Ignored moving container {} from CLOSING to CLOSED
state because replica bcsId ({}) " +
+ "reported by datanode {} does not match sequenceId ({{}}).",
+ containerId, replica.getBlockCommitSequenceId(), datanode,
container.getSequenceId());
+ return true;
+ }
logger.info("Moving container {} to CLOSED state, datanode {} " +
- "reported CLOSED replica with index {}.", containerId, datanode,
+ "reported CLOSED replica with index {}.", containerId,
datanode,
Review Comment:
This is a log identical to line 342, maybe add the pre state (Closing, Quasi
Closed) as well to the log message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
