adoroszlai opened a new pull request, #7979: URL: https://github.com/apache/ozone/pull/7979
## What changes were proposed in this pull request? Names of config properties defined in classes annotated with `@ConfigGroup(prefix)` and `@Config(key)` are derived as `prefix.key`. `prefix` currently must not be included in `key`. However, prefix is internal to the codebase, actual configuration (`ozone-site.xml`) uses the full name. People tend to search the code for the full name. This PR makes the logic related to these annotations more flexible, by allowing the prefix to be repeated in the key. That is, also accept `@Config(prefix.key)`, and treat `prefix.key` as the full name, without adding `prefix` again. Also: - change the prefix used by tests in `hdds-config` to avoid real configuration keys - add the prefix in some config keys in `ScmConfig` and `OzoneClientConfig` as a start Other configuration classes are to be updated in follow-up task. https://issues.apache.org/jira/browse/HDDS-12424 ## How was this patch tested? Added test case in `TestConfigurationSource`. Existing unit tests for the rest of the changes, including `OzoneClientConfig`. https://github.com/adoroszlai/ozone/actions/runs/13565082698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
