devabhishekpal commented on code in PR #7786:
URL: https://github.com/apache/ozone/pull/7786#discussion_r1974847313
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/fsck/TestContainerHealthTask.java:
##########
@@ -293,10 +317,19 @@ public void testRun() throws Exception {
// Just check once again that count remains consistent
LambdaTestUtils.await(60000, 1000, () ->
(unHealthyContainersTableHandle.count() == 2));
+
+ // Since other container states have been changing, but no change in
UNDER_REPLICATED
+ // container count, UNDER_REPLICATED count metric should not be affected
from previous
+ // assertion count.
+ assertEquals(1, containerHealthMetrics.getUnderReplicatedContainerCount());
+ assertEquals(0, containerHealthMetrics.getMissingContainerCount());
+
+ containerHealthTask.stop();
}
@Test
public void testDeletedContainer() throws Exception {
+ System.out.println("TestContainerHealthTask: testDeletedContainer Start");
Review Comment:
I think this print statement might be added for debug. Would it be okay to
remove them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
