siddhantsangwan commented on code in PR #7985:
URL: https://github.com/apache/ozone/pull/7985#discussion_r1974874004
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/health/MismatchedReplicasHandler.java:
##########
@@ -95,23 +89,23 @@ public boolean handle(ContainerCheckRequest request) {
}
/**
- * If a CLOSED or QUASI-CLOSED container has an OPEN or CLOSING replica,
- * there is a state mismatch. QUASI_CLOSED replica of a CLOSED container
- * should be closed if their sequence IDs match.
+ * Returns the final expected closed state type based on the scm container
state and the replica state.
* @param replica replica to check for mismatch and if it should be closed
- * @return true if the replica should be closed, else false
+ * @return non null closed state if the replica should be closed, else
CLOSED/QUASI_CLOSED based on the replica's
+ * state.
Review Comment:
```suggestion
* @return null if the replica should not be closed, else
CLOSED/QUASI_CLOSED based on the replica's
* state.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
