nandakumar131 commented on PR #7965: URL: https://github.com/apache/ozone/pull/7965#issuecomment-2690195149
Thanks @symious for following up. The blocks that get's deleted is subset of the allocated blocks, so if logging block IDs during delete block is flooding the log file, the allocate block will also end up doing the same. But I see that we already are adding audit log for allocate block call, so this is not something new to worry about. There is also some work going on to pre-allocate blocks ([HDDS-11894](https://issues.apache.org/jira/browse/HDDS-11894)), that will have impact once we start adding block Ids to the audit log. I see why we might need block Ids for debugging in some cases. Will it work for you, if the block Ids are added in regular `debug` log rather than to the audit log? By adding it as debug log, we will have more control on enabling/disabling the log by setting the log level in log4j.properties for this specific class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
