adoroszlai commented on code in PR #7971:
URL: https://github.com/apache/ozone/pull/7971#discussion_r1975249267


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestDataUtil.java:
##########
@@ -111,6 +111,20 @@ public static void createKey(OzoneBucket bucket, String 
keyName,
         ReplicationType.RATIS, content);
   }
 
+  public static void createKey(OzoneBucket bucket, String keyName,
+                               byte[] content) throws IOException {
+    createKey(bucket, keyName, ReplicationFactor.ONE,
+        ReplicationType.RATIS, new String(content, UTF_8));

Review Comment:
   `createKey(..., String)` should call `createKey(..., byte[])`, not the other 
way around.
   
   Because `createKey(..., String)` writes bytes after all:
   
   
https://github.com/apache/ozone/blob/7b48861a9b44bc4c47a948f32582963153a8b388/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestDataUtil.java#L142



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to