smengcl commented on code in PR #7976:
URL: https://github.com/apache/ozone/pull/7976#discussion_r1976096769
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/TestContainerReportHandler.java:
##########
@@ -446,64 +484,70 @@ public void testClosingToClosedForECContainer()
}
/**
- * Tests that a DELETING RATIS container transitions to CLOSED if a
non-empty CLOSED replica is reported. It does not
- * transition if a non-empty CLOSING replica is reported.
+ * Tests that a DELETING or DELETED RATIS container transitions to CLOSED if
a non-empty replica in OPEN, CLOSING,
+ * CLOSED, QUASI_CLOSED or UNHEALTHY state is reported. It should not
transition if the replica is in INVALID or
+ * DELETED states.
*/
- @Test
- public void
ratisContainerShouldTransitionFromDeletingToClosedWhenNonEmptyClosedReplica()
throws IOException {
- ContainerInfo container = getContainer(LifeCycleState.DELETING);
+ @ParameterizedTest
+ @MethodSource("containerAndReplicaStates")
+ public void
ratisContainerShouldTransitionFromDeletingOrDeletedToClosedWhenNonEmptyReplica(
Review Comment:
I checked/tried and it looks to me there are still subtle differences
between these. I'll probably not going to bother refactoring this in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
