ChenSammi commented on PR #7722: URL: https://github.com/apache/ozone/pull/7722#issuecomment-2693972367
> @ChenSammi updated the comments and code, plz review again Per we offline discussion, I will suggest to start a feature branch for all these pre-ratis execution changes, as the idea of keeping both pre-ratis execution and current per-ratis execution work is really a ideal state. But mixing the code makes it complex, hard to understand clearly, and easy to go wrong on many edge cases, for example, this new Index should not the turned on until only the OM leader will call the IndexGenerator#nextIndex(). A feature branch will save the master from broken due to intermediate development state, cases not covered, bugs, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
