jojochuang commented on code in PR #7986:
URL: https://github.com/apache/ozone/pull/7986#discussion_r1977998419
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMPerformanceMetrics.java:
##########
@@ -151,6 +152,15 @@ public static void unregister() {
@Metric(about = "ACLs check in getObjectTagging")
private MutableRate getObjectTaggingAclCheckLatencyNs;
+ @Metric(about = "Latency of DirectoryDeletingService in ms")
Review Comment:
This is fine. It would be even better if it is more specific, like:
```suggestion
@Metric(about = "Latency of DirectoryDeletingService in each iteration in
ms")
```
Months later when I look at it again, I am not going to remember how it is
calculated and would wonder what does "Latency of DirectoryDeletingService in
ms" mean exactly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
