adoroszlai commented on code in PR #7996:
URL: https://github.com/apache/ozone/pull/7996#discussion_r1980055263


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/multitenant/MultiTenantAccessController.java:
##########
@@ -504,4 +508,18 @@ public Policy build() {
       }
     }
   }
+
+  /** Create {@code MultiTenantAccessController} implementation. */
+  static MultiTenantAccessController create(ConfigurationSource conf) {
+    if (conf.getBoolean(OZONE_OM_TENANT_DEV_SKIP_RANGER, false)) {
+      return new InMemoryMultiTenantAccessController();
+    }
+
+    final String className = 
"org.apache.hadoop.ozone.om.multitenant.RangerClientMultiTenantAccessController";
+    return ReflectionUtils.newInstance(

Review Comment:
   Ranger depends on Ozone for the authorizer plugin.  Ozone depends on Ranger 
for a specific implementation of multitenancy.  To break the circular 
dependency, I'd like to extract this to a separate module (HDDS-12454).  By 
using reflection, OM will not have compile-time dependency on Ranger.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to