[
https://issues.apache.org/jira/browse/HDDS-12482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai updated HDDS-12482:
------------------------------------
Description:
CommonConfigurationKeys is private and unstable. We should use
CommonConfigurationKeysPublic instead.
{code:title=CommonConfigurationKeys usage}
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeClientProtocolServer.java
31:import org.apache.hadoop.fs.CommonConfigurationKeys;
69: if
(conf.getBoolean(CommonConfigurationKeys.HADOOP_SECURITY_AUTHORIZATION,
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/http/HttpServer2.java
65:import org.apache.hadoop.fs.CommonConfigurationKeys;
762: CommonConfigurationKeys.HADOOP_HTTP_LOGS_ENABLED,
763: CommonConfigurationKeys.HADOOP_HTTP_LOGS_ENABLED_DEFAULT);
770: CommonConfigurationKeys.HADOOP_JETTY_LOGS_SERVE_ALIASES,
771: CommonConfigurationKeys.DEFAULT_HADOOP_JETTY_LOGS_SERVE_ALIASES))
{
1442:
CommonConfigurationKeys.HADOOP_SECURITY_INSTRUMENTATION_REQUIRES_ADMIN,
1467: CommonConfigurationKeys.HADOOP_SECURITY_AUTHORIZATION, false)) {
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMBlockProtocolServer.java
47:import org.apache.hadoop.fs.CommonConfigurationKeys;
148: if
(conf.getBoolean(CommonConfigurationKeys.HADOOP_SECURITY_AUTHORIZATION,
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java
53:import org.apache.hadoop.fs.CommonConfigurationKeys;
189: if
(conf.getBoolean(CommonConfigurationKeys.HADOOP_SECURITY_AUTHORIZATION,
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMDatanodeProtocolServer.java
54:import org.apache.hadoop.fs.CommonConfigurationKeys;
183: if
(conf.getBoolean(CommonConfigurationKeys.HADOOP_SECURITY_AUTHORIZATION,
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/tools/contract/AbstractContractDistCpTest.java
20:import static
org.apache.hadoop.fs.CommonConfigurationKeys.IOSTATISTICS_LOGGING_LEVEL_INFO;
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/common/BekInfoUtils.java
26:import org.apache.hadoop.fs.CommonConfigurationKeys;
45: CommonConfigurationKeys.HADOOP_SECURITY_KEY_PROVIDER_PATH,
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
151:import org.apache.hadoop.fs.CommonConfigurationKeys;
1332: if
(conf.getBoolean(CommonConfigurationKeys.HADOOP_SECURITY_AUTHORIZATION,
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconStorageContainerManagerFacade.java
62:import org.apache.hadoop.fs.CommonConfigurationKeys;
599: CommonConfigurationKeys.IPC_MAXIMUM_DATA_LENGTH,
600: CommonConfigurationKeys.IPC_MAXIMUM_DATA_LENGTH_DEFAULT);
{code}
{code:title=public constants, can be replaced}
public static final String HADOOP_HTTP_LOGS_ENABLED =
public static final boolean HADOOP_HTTP_LOGS_ENABLED_DEFAULT = true;
public static final String HADOOP_SECURITY_AUTHORIZATION =
public static final String HADOOP_SECURITY_INSTRUMENTATION_REQUIRES_ADMIN =
public static final String HADOOP_SECURITY_KEY_PROVIDER_PATH =
{code}
{code:title=private constants, consider removing}
public static final boolean DEFAULT_HADOOP_JETTY_LOGS_SERVE_ALIASES =
public static final String HADOOP_JETTY_LOGS_SERVE_ALIASES =
public static final String IOSTATISTICS_LOGGING_LEVEL_INFO
public static final String IPC_MAXIMUM_DATA_LENGTH =
public static final int IPC_MAXIMUM_DATA_LENGTH_DEFAULT = 128 * 1024 * 1024;
{code}
If all usage of CommonConfigurationKeys can be replaced or removed, we should
also add a ban for import in root {{pom.xml}}.
was:CommonConfigurationKeys is private and unstable. We should use
CommonConfigurationKeysPublic instead.
> Avoid using CommonConfigurationKeys
> -----------------------------------
>
> Key: HDDS-12482
> URL: https://issues.apache.org/jira/browse/HDDS-12482
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: build
> Reporter: Attila Doroszlai
> Assignee: Attila Doroszlai
> Priority: Major
>
> CommonConfigurationKeys is private and unstable. We should use
> CommonConfigurationKeysPublic instead.
> {code:title=CommonConfigurationKeys usage}
> hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeClientProtocolServer.java
> 31:import org.apache.hadoop.fs.CommonConfigurationKeys;
> 69: if
> (conf.getBoolean(CommonConfigurationKeys.HADOOP_SECURITY_AUTHORIZATION,
> hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/http/HttpServer2.java
> 65:import org.apache.hadoop.fs.CommonConfigurationKeys;
> 762: CommonConfigurationKeys.HADOOP_HTTP_LOGS_ENABLED,
> 763: CommonConfigurationKeys.HADOOP_HTTP_LOGS_ENABLED_DEFAULT);
> 770: CommonConfigurationKeys.HADOOP_JETTY_LOGS_SERVE_ALIASES,
> 771:
> CommonConfigurationKeys.DEFAULT_HADOOP_JETTY_LOGS_SERVE_ALIASES)) {
> 1442:
> CommonConfigurationKeys.HADOOP_SECURITY_INSTRUMENTATION_REQUIRES_ADMIN,
> 1467: CommonConfigurationKeys.HADOOP_SECURITY_AUTHORIZATION, false)) {
> hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMBlockProtocolServer.java
> 47:import org.apache.hadoop.fs.CommonConfigurationKeys;
> 148: if
> (conf.getBoolean(CommonConfigurationKeys.HADOOP_SECURITY_AUTHORIZATION,
> hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java
> 53:import org.apache.hadoop.fs.CommonConfigurationKeys;
> 189: if
> (conf.getBoolean(CommonConfigurationKeys.HADOOP_SECURITY_AUTHORIZATION,
> hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMDatanodeProtocolServer.java
> 54:import org.apache.hadoop.fs.CommonConfigurationKeys;
> 183: if
> (conf.getBoolean(CommonConfigurationKeys.HADOOP_SECURITY_AUTHORIZATION,
> hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/tools/contract/AbstractContractDistCpTest.java
> 20:import static
> org.apache.hadoop.fs.CommonConfigurationKeys.IOSTATISTICS_LOGGING_LEVEL_INFO;
> hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/common/BekInfoUtils.java
> 26:import org.apache.hadoop.fs.CommonConfigurationKeys;
> 45: CommonConfigurationKeys.HADOOP_SECURITY_KEY_PROVIDER_PATH,
> hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
> 151:import org.apache.hadoop.fs.CommonConfigurationKeys;
> 1332: if
> (conf.getBoolean(CommonConfigurationKeys.HADOOP_SECURITY_AUTHORIZATION,
> hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconStorageContainerManagerFacade.java
> 62:import org.apache.hadoop.fs.CommonConfigurationKeys;
> 599: CommonConfigurationKeys.IPC_MAXIMUM_DATA_LENGTH,
> 600: CommonConfigurationKeys.IPC_MAXIMUM_DATA_LENGTH_DEFAULT);
> {code}
> {code:title=public constants, can be replaced}
> public static final String HADOOP_HTTP_LOGS_ENABLED =
> public static final boolean HADOOP_HTTP_LOGS_ENABLED_DEFAULT = true;
> public static final String HADOOP_SECURITY_AUTHORIZATION =
> public static final String HADOOP_SECURITY_INSTRUMENTATION_REQUIRES_ADMIN =
> public static final String HADOOP_SECURITY_KEY_PROVIDER_PATH =
> {code}
> {code:title=private constants, consider removing}
> public static final boolean DEFAULT_HADOOP_JETTY_LOGS_SERVE_ALIASES =
> public static final String HADOOP_JETTY_LOGS_SERVE_ALIASES =
> public static final String IOSTATISTICS_LOGGING_LEVEL_INFO
> public static final String IPC_MAXIMUM_DATA_LENGTH =
> public static final int IPC_MAXIMUM_DATA_LENGTH_DEFAULT = 128 * 1024 * 1024;
> {code}
> If all usage of CommonConfigurationKeys can be replaced or removed, we should
> also add a ban for import in root {{pom.xml}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
