adoroszlai commented on code in PR #8017:
URL: https://github.com/apache/ozone/pull/8017#discussion_r1983731202
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/TestCloseContainer.java:
##########
@@ -109,8 +106,7 @@ public void
testReplicasAreReportedForClosedContainerAfterRestart()
throws Exception {
// Create some keys to write data into the open containers
for (int i = 0; i < 10; i++) {
- TestDataUtil.createKey(bucket, "key" + i, ReplicationConfig
- .fromTypeAndFactor(ReplicationType.RATIS, ReplicationFactor.THREE),
+ TestDataUtil.createKey(bucket, "key" + i, null,
Review Comment:
No need to pass `null` as `ReplicationConfig`, since we have
`createKey(OzoneBucket, String, byte[])`.
```suggestion
TestDataUtil.createKey(bucket, "key" + i,
```
(Applies to all invocations where third parameter is `null`.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
