chiacyu commented on code in PR #8034:
URL: https://github.com/apache/ozone/pull/8034#discussion_r1986326337
##########
hadoop-hdds/client/dev-support/findbugsExcludeFile.xml:
##########
@@ -19,4 +19,16 @@
<Class name="org.apache.hadoop.hdds.scm.storage.ByteArrayReader"></Class>
<Bug pattern="EI_EXPOSE_REP2" /> <!-- "Deep copy byte[] has bad impact on
performance" -->
</Match>
+ <Match>
+ <Class
name="org.apache.hadoop.hdds.scm.storage.DummyBlockInputStreamWithRetry"/>
+ <Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT" />
+ </Match>
+ <Match>
+ <Class name="org.apache.hadoop.hdds.scm.storage.TestBlockInputStream"/>
+ <Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT" />
+ </Match>
+ <Match>
+ <Class
name="org.apache.hadoop.ozone.client.io.TestBlockInputStreamFactoryImpl"/>
+ <Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT" />
+ </Match>
Review Comment:
Hi, @adoroszlai
Thanks for the point out, which one would be better? How about we hold on
the `doReturn()` changes, but I would still create a subtask of
[HDDS-12338](https://issues.apache.org/jira/browse/HDDS-12338) for that? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
