jojochuang commented on code in PR #8020: URL: https://github.com/apache/ozone/pull/8020#discussion_r1988081046
########## hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/SignedChunksInputStream.java: ########## @@ -23,19 +23,26 @@ import java.util.regex.Pattern; /** - * Input stream implementation to read body with chunked signatures. - * <p> - * see: https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-streaming.html + * Input stream implementation to read body with chunked signatures. This should also work + * with the chunked payloads with trailer. + * + * Note that there are no actual chunk signature verification taking place. The InputStream only + * returns the actual chunk payload from chunked signatures format. Review Comment: I am not familiar with AWS Signature Version 4 but does it mean there'll be a follow up task to verify chunk signatures? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
