ChenSammi commented on code in PR #8009:
URL: https://github.com/apache/ozone/pull/8009#discussion_r1986722077
##########
hadoop-hdds/interface-server/src/main/proto/ScmServerDatanodeHeartbeatProtocol.proto:
##########
@@ -499,6 +499,8 @@ message DiskBalancerReportProto {
required bool isRunning = 1;
optional uint64 balancedBytes = 2;
optional DiskBalancerConfigurationProto diskBalancerConf = 3;
+ optional int64 successCount = 4;
Review Comment:
successCount -> successMoveCount
failureCount -> failureMoveCount
Please make sure the naming is consistent cross multiple data structure.
For example, you either name both as sucessCount in DiskBalancerReportProto and
DatanodeDiskBalancerInfoProto, or both as successMoveCount.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
