adoroszlai commented on code in PR #8050:
URL: https://github.com/apache/ozone/pull/8050#discussion_r1989826869


##########
hadoop-ozone/dist/src/main/smoketest/admincli/container.robot:
##########
@@ -96,6 +96,33 @@ List all containers from a particular container ID
     ${output} =         Execute          ozone admin container list --all 
--start 1
                         Should contain   ${output}   OPEN
 
+List containers in JSON array format
+    ${output} =         Execute          ozone admin container list --json | 
jq -r '.'
+                        Should Start With   ${output}   [

Review Comment:
   > `ozone admin container list --json | jq '.[] | .containerID'`
   
   I suggest splitting it into two commands:
   
   ```
   ${output} =     Execute    <command returns JSON>
   ${excerpt} =    Execute    echo '${output}' | jq '....'
   ```
   
   This has the benefit of showing raw output, which helps in case `jq` fails 
to find expected structure.  Plus you can reuse `output` for multiple 
extractions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org

Reply via email to