sadanand48 commented on code in PR #7957: URL: https://github.com/apache/ozone/pull/7957#discussion_r1993646076
########## hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java: ########## @@ -2666,6 +2666,17 @@ public void deleteObjectTagging(OmKeyArgs args) throws IOException { handleError(omResponse); } + @Override + public void compactOMDB(String columnFamily) throws IOException { + OzoneManagerProtocolProtos.CompactRequest compactRequest = + OzoneManagerProtocolProtos.CompactRequest.newBuilder() + .setColumnFamily(columnFamily) + .build(); + OMRequest omRequest = createOMRequest(Type.CompactDB) + .setCompactRequest(compactRequest).build(); + handleError(submitRequest(omRequest)); Review Comment: another simpler alternative is to use this method from [omAdminProtocol](https://github.com/apache/ozone/blob/5e28acb71de7bf9fcc70c17b2fe8db85b2f354db/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OMAdminProtocolClientSideImpl.java#L79). This should serve the purpose here ``` java /** * Create OM Admin Protocol Client for contacting the given OM (does not * failover to different OM). Use for admin commands such as * getOMConfiguration which are targeted to a specific OM. */ public static OMAdminProtocolClientSideImpl createProxyForSingleOM( ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org