xichen01 commented on code in PR #8008:
URL: https://github.com/apache/ozone/pull/8008#discussion_r1997645169


##########
hadoop-ozone/ozonefs-shaded/pom.xml:
##########
@@ -120,38 +151,70 @@
                 <relocation>
                   <pattern>org</pattern>
                   <shadedPattern>${shaded.prefix}.org</shadedPattern>
-                  <includes>
-                    <include>org.yaml.**.*</include>
-                    <include>org.sqlite.**.*</include>
-                    <include>org.tukaani.**.*</include>
-                    <include>org.bouncycastle.**.*</include>
-                    <include>org.rocksdb.**.*</include>
-                    <include>org.apache.commons.cli.**.*</include>
-                    <include>org.apache.commons.compress.**.*</include>
-                    <include>org.apache.commons.codec.**.*</include>
-                    <include>org.apache.commons.beanutils.**.*</include>
-                    <include>org.apache.commons.collections.**.*</include>
-                    <include>org.apache.commons.digester.**.*</include>
-                    <include>org.apache.commons.io.**.*</include>
-                    <include>org.apache.commons.logging.**.*</include>
-                    <include>org.apache.commons.validator.**.*</include>
-                    <include>org.apache.commons.lang3.**.*</include>
-                    <include>org.sqlite.**.*</include>
-                    <include>org.apache.thrift.**.*</include>
-                  </includes>
+                  <excludes>
+                    <exclude>org.apache.hadoop.**</exclude>
+                    <exclude>org.apache.log4j.**</exclude>
+                    <exclude>org.apache.ozone.**</exclude>
+                    <exclude>org.apache.ratis.**</exclude>
+                    <!-- These packages are the ones that are not shaded in 
the hadoop release package.
+                      To prevent conflicts, we do not include these packages 
in the ozone client release package.
+                      Ozone will use hadoop / JVM to provide these 
dependencies. -->
+                    <exclude>org.ietf.jgss.*</exclude>
+                    <exclude>org.omg.**</exclude>
+                    <exclude>org.slf4j.**</exclude>
+                    <exclude>org.w3c.dom.**</exclude>
+                    <exclude>org.xerial.snappy.**</exclude>
+                    <exclude>org.xml.sax.**</exclude>
+                    <exclude>org.wildfly.**</exclude>
+                  </excludes>
+                </relocation>
+                <relocation>
+                  <pattern>org.apache.ratis</pattern>
+                  
<shadedPattern>${shaded.prefix}.org.apache.ratis</shadedPattern>
+                  <!-- thirdparty netty will use native library and cannot be 
relocated -->
+                  <excludes>
+                    <exclude>org.apache.ratis.thirdparty.io.netty.**</exclude>

Review Comment:
   Netty native libraries have been relocated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to