swamirishi commented on code in PR #8098:
URL: https://github.com/apache/ozone/pull/8098#discussion_r1997684452
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/OzoneManagerServiceProviderImpl.java:
##########
@@ -269,36 +270,145 @@ public void start() {
.values()
.forEach(ReconOmTask::init);
- // Verify if 'OmDeltaRequest' task's lastUpdatedSeqNumber number not
matching with
+ // Verify if 'OmDeltaRequest' task's lastUpdatedSeqNumber is greater than
zero and greater than
+ // 'OmSnapshotRequest' task's lastUpdatedSeqNumber number and not matching
with
// lastUpdatedSeqNumber number for any of the OM task, then just run
reprocess for such tasks.
+
+ ReconTaskStatusUpdater fullSnapshotTaskStatusUpdater =
+
taskStatusUpdaterManager.getTaskStatusUpdater(OmSnapshotTaskName.OmSnapshotRequest.name());
Review Comment:
Why have a new fullSnapshotTaskStatusUpdater ? We can update the same
variable irrespective of it being a delta process or reprocess.
We just have to bootstrap if there is difference between omSnapshot & OM
Leader sequence number and provided all TaskStatusUpdater tasks =
OmSnapshot.sequenceNumber. On end of every process or reprocess we should just
update the sequenceNumber in taskStatusUpdater to the OmSnapshot's sequence
number. If it doesn't match we should just run reprocess if the value is 0 or
rerun process from the seekPos. Isn't this possible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
