peterxcli commented on PR #8090: URL: https://github.com/apache/ozone/pull/8090#issuecomment-2734441901
> It seems my suggestion resulted in change to many files. If you have the time, we could reduce that a bit by: > > 1. Convert reflection-related exceptions in `getPolicy` instead of its callers. The simplest way is using `org.apache.ratis.util.ReflectionUtils`. > 2. Let `KeyValueHandler` and `ContainerImporter` create the policy if they get `null` instance (for tests). > > Feel free to ignore these if you wish, since you have already made the changes. Thanks @adoroszlai for the suggestion, code is much cleaner. btw, I didn't do the cleanup for `ContainerImporter` cause it has few references. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
