SaketaChalamchala commented on code in PR #8123:
URL: https://github.com/apache/ozone/pull/8123#discussion_r2008165502
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/SnapshotDeletingService.java:
##########
@@ -173,13 +173,18 @@ public BackgroundTaskResult call() throws
InterruptedException {
// another.
if (nextSnapshot != null &&
nextSnapshot.getSnapshotStatus() !=
SnapshotInfo.SnapshotStatus.SNAPSHOT_ACTIVE) {
+ LOG.info("Skipping Snapshot Deletion processing for : {}",
snapInfo.getTableKey());
Review Comment:
@hemantk-12,
2. Should this log be `Skipping Snapshot Deletion processing because the
snapshot is active or DB changes are not flushed: {}`? and do we want to add
this even as a debug log? Wouldn't it be cleaner for `SnapshotDeletingService`
to log the progress of snapshots marked for deletion only? In which case, 1.
might also not be necessary.
Otherwise, everytime `SnapshotDeletingService` runs we will see logs for all
snapshots, most of which will say "not deleting this snapshot because it is
active" which may not indicate anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
