ChenSammi commented on PR #8127: URL: https://github.com/apache/ozone/pull/8127#issuecomment-2746827590
> > has the chance to be deleted later for reasons such as mis-replicated. > > Any container has this chance. Even if a container was push replicated due to mis-replication, there is only a 1 in 3 chance that it will be the one that gets deleted. In fact, the disk balancer could be running on another node and that is the one that is selected for delete, and there is no check for that. > > Normally, there will be no replication going on. A cluster should not be continuously replicating. Therefore the chances of the disk balancer moving a container that is just about to be deleted is likely very small, and if it does, its just a small amount of wasted work. > > While this change is not over large, it adds complexity in both the implementation and tests which must be understood now and in the future and probably isn't worth it. I don't favor complexity too. But the IO resources on datanode are very precious, data read, write, scan, replication, raft, rocksdb. So it naturally come with idea to save potential wasted IO resources, which I believe is not hard to understand. Implementation wise, comment to explain the motivation is required, others we will see. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
