peterxcli opened a new pull request, #8142: URL: https://github.com/apache/ozone/pull/8142
## What changes were proposed in this pull request? Currently the checkLeaderStatus check does nothing, it return the leader status & ignores https://github.com/apache/ozone/blob/57fda0c32704b76b78152f5b16bc9a7c923167ac/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java#L360 After checking the codebase, found there is no need for `OzoneManagerRatisServer#checkLeaderStatus`. As it already performed the check before calling `omRatisServer.addOMToRatisRing(newOmNode)` and `omRatisServer.removeOMFromRatisRing(newOmNode)` - https://github.com/apache/ozone/blob/1b0e912f53d139fc098bf057f7872774bdc7ca50/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OMInterServiceProtocolServerSideImpl.java#L56 - https://github.com/apache/ozone/blob/1b0e912f53d139fc098bf057f7872774bdc7ca50/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OMAdminProtocolServerSideImpl.java#L87 ### Additional context `OzoneManagerRatisUtils#checkLeaderStatus`: https://github.com/apache/ozone/blob/6ebd5921f6087913ee1dfe100dd2806c9bb5c4ec/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/utils/OzoneManagerRatisUtils.java#L497-L505 `OzoneManager#checkLeaderStatus`: https://github.com/apache/ozone/blob/6ebd5921f6087913ee1dfe100dd2806c9bb5c4ec/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java#L4220-L4240 `OzoneManagerRatisServer#checkLeaderStatus`: https://github.com/apache/ozone/blob/6ebd5921f6087913ee1dfe100dd2806c9bb5c4ec/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java#L825-L841 ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-12648 ## How was this patch tested? CI: https://github.com/peterxcli/ozone/actions/runs/14020769117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
