[ 
https://issues.apache.org/jira/browse/HDDS-12596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937982#comment-17937982
 ] 

Saketa Chalamchala edited comment on HDDS-12596 at 3/24/25 7:01 PM:
--------------------------------------------------------------------

Hi Peter, Have you started working on the fix already? If you are then I can 
close HDDS-11817 as a duplicate. We want to ultimately use 
ozone.om.fs.snapshot.max.limit to limit the number of snapshots created in 
Ozone. We also wanted this fix merged sooner in the next few weeks.

Just to provide a little bit of context. This ozone.om.fs.snapshot.max.limit 
was first introduced in HDDS-7224 to limit the max number of snapshots created 
and later implementation using this config was removed.  

The fix may involve updating to verify & limit the number of snapshots created 
in 
[OMSnapshotCreateRequest.java|https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java#L132]

 


was (Author: JIRAUSER297030):
Hi Peter, Have you started working on the fix already? If you are then I can 
close HDDS-11817 as a duplicate. We want to ultimately use 
ozone.om.fs.snapshot.max.limit to limit the number of snapshots created in 
Ozone.

Just to provide a little bit of context. This ozone.om.fs.snapshot.max.limit 
was first introduced in HDDS-7224 to limit the max number of snapshots created 
and later implementation using this config was removed.  

The fix may involve updating to verify & limit the number of snapshots created 
in 
[OMSnapshotCreateRequest.java|https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java#L132]

> OM fs snapshot max limit is not enforced
> ----------------------------------------
>
>                 Key: HDDS-12596
>                 URL: https://issues.apache.org/jira/browse/HDDS-12596
>             Project: Apache Ozone
>          Issue Type: Bug
>          Components: Snapshot
>            Reporter: Tsz-wo Sze
>            Assignee: Peter Lee
>            Priority: Major
>
> {code:xml}
> //ozone-default.xml
>   <property>
>     <name>ozone.om.fs.snapshot.max.limit</name>
>     <value>1000</value>
>     <tag>OZONE, OM, MANAGEMENT</tag>
>     <description>
>       The maximum number of filesystem snapshot allowed in an Ozone Manager.
>     </description>
>   </property>
> {code}
> The value of the above property is passed to RDBStore but it is never used.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org

Reply via email to