adoroszlai commented on code in PR #8152:
URL: https://github.com/apache/ozone/pull/8152#discussion_r2011973089


##########
hadoop-ozone/pom.xml:
##########
@@ -147,6 +148,12 @@
         <artifactId>hdds-server-framework</artifactId>
         <version>${hdds.version}</version>
       </dependency>
+      <dependency>
+        <groupId>org.apache.ozone</groupId>
+        <artifactId>hdds-server-framework</artifactId>
+        <version>${hdds.version}</version>
+        <type>test-jar</type>
+      </dependency>

Review Comment:
   Thanks @ivandika3 for the review.
   
   > is this "test-jar" for hdds-server-framework necessary?
   
   It is required for the `MockSpaceUsageCheckFactory$None` configured in 
`ozone-site.xml`.  Removed now, since it's not essential for the S3 tests, but 
had to add the normal jar as dependency.  Also added some other used undeclared 
ones.  And filed HDDS-12689 to add some missing ones for SDK v2.
   
   > After this is merged, HDDS-11879 will be fixed?
   
   We will need some additional changes to fix HDDS-11879.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to