peterxcli opened a new pull request, #8157:
URL: https://github.com/apache/ozone/pull/8157
## What changes were proposed in this pull request?
```xml
//ozone-default.xml
<property>
<name>ozone.om.fs.snapshot.max.limit</name>
<value>1000</value>
<tag>OZONE, OM, MANAGEMENT</tag>
<description>
The maximum number of filesystem snapshot allowed in an Ozone Manager.
</description>
</property>
```
The value of the above property is passed to RDBStore but it is never used.
We should verify & limit the number of snapshots created in
`OMSnapshotCreateRequest`.
- Get non-deleted rows count directly from `NumSnapshotActive` metrics.
- It would be prepared on the OM node restart, and be inc/dec on
`TestOMSnapshotCreateRequest`/`TestOMSnapshotDeleteRequest`. So it would
reflect the real snapshotTable row count.
https://github.com/apache/ozone/blob/a4d878ef7ad0bd8697fddffa689b8159ca22df1f/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java#L1949-L1980
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12596
## How was this patch tested?
CI:
https://github.com/peterxcli/ozone/actions/runs/14060484307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
