errose28 commented on PR #8145: URL: https://github.com/apache/ozone/pull/8145#issuecomment-2751604022
IMO we should favor debug and repair tools that are a more generic vs. explicitly tailored to a specific bug. The later approach creates more tools that we need to maintain but end up getting used far less after the bug is fixed. Along these lines, I filed HDDS-12692 to support filtering by replication type and/or factor in `ozone debug replicas verify` since there may be bugs that only affect Ratis or EC keys. However I think that the specific key size check that is used to filter if keys are pre-disposed to this bug is too specific to this one case to warrant maintaining forever and the block metadata/existence check is a better approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
