ChenSammi commented on code in PR #8165:
URL: https://github.com/apache/ozone/pull/8165#discussion_r2015554495
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/ContainerLogger.java:
##########
@@ -149,6 +150,20 @@ public static void logRecovered(ContainerData
containerData) {
LOG.info(getMessage(containerData));
}
+ /**
+ * Logged when a container is successfully moved from one data volume to
another.
+ *
+ * @param containerId The ID of the moved container.
+ * @param sourceVolume The source volume path.
+ * @param destinationVolume The destination volume path.
+ * @param containerSize The size of data moved from container in bytes.
+ * @param timeTaken The time taken for the move in milliseconds.
+ */
+ public static void logMoveSuccess(long containerId, HddsVolume sourceVolume,
Review Comment:
Use StorageVolume instead of HddsVolume here. In general, we should use
interface class or abstract class, instead of detail child class if child class
is not a must to have, so the code will be more general, can cover other child
classes of the interface class or abstract class in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
