swamirishi commented on code in PR #8157: URL: https://github.com/apache/ozone/pull/8157#discussion_r2021892047
########## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java: ########## @@ -104,6 +104,8 @@ public OMSnapshotCreateRequest(OMRequest omRequest) { @RequireSnapshotFeatureState(true) public OMRequest preExecute(OzoneManager ozoneManager) throws IOException { final OMRequest omRequest = super.preExecute(ozoneManager); + // verify snapshot limit + ozoneManager.getOmSnapshotManager().validateSnapshotLimit(); Review Comment: yeah this validation should move to the validateAndUpdateCacheMethod -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org