[
https://issues.apache.org/jira/browse/HDDS-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HDDS-12750:
----------------------------------
Labels: pull-request-available (was: )
> Move StorageTypeProto from ScmServerDatanodeHeartbeatProtocol.proto to
> hdds.proto
> ---------------------------------------------------------------------------------
>
> Key: HDDS-12750
> URL: https://issues.apache.org/jira/browse/HDDS-12750
> Project: Apache Ozone
> Issue Type: Improvement
> Components: common
> Reporter: Tsz-wo Sze
> Assignee: Tsz-wo Sze
> Priority: Major
> Labels: pull-request-available
>
> TLDR: The change is wire compatible but requires updating protolock.
> In the PR of HDDS-11351, [~XiChen] pointed out that both hdds.proto and
> ScmServerDatanodeHeartbeatProtocol.proto have the same proto package
> "hadoop.hdds". So, we could safely move StorageTypeProto from
> ScmServerDatanodeHeartbeatProtocol.proto to hdds.proto. The only difference
> is the java_outer_classname. Fortunately,
> ScmServerDatanodeHeartbeatProtocol.proto is a non-user facing internal
> protocol and the change is wire compatible. (It is API incompatible but it is
> fine since the protocol is not a public API.) So there are no compatibility
> issues.
> A problem is that we need to update the protolock file. We should also rename
> ScmServerDatanodeHeartbeatProtocol.proto to
> StorageContainerDatanodeProtocol.proto, i.e. make it consistent with its
> java_outer_classname.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
