adoroszlai commented on code in PR #8180:
URL: https://github.com/apache/ozone/pull/8180#discussion_r2023072830
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -73,10 +73,17 @@ public class DatanodeConfiguration extends
ReconfigurableConfig {
"hdds.datanode.disk.check.min.gap";
public static final String DISK_CHECK_TIMEOUT_KEY =
"hdds.datanode.disk.check.timeout";
+
+ // Minimum space should be left on volume.
+ // Ex: If volume has 1000GB and minFreeSpace is configured as 10GB,
+ // In this case when availableSpace is 990GB or below, volume is assumed as
full
Review Comment:
> `when availableSpace is 990GB or below, volume is assumed as full`
This doesn't sound right. Volume is full if `availableSpace <= 10GB`, or
`usedSpace >= 990GB`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
