ChenSammi commented on code in PR #8181: URL: https://github.com/apache/ozone/pull/8181#discussion_r2022481947
########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/StorageVolume.java: ########## @@ -459,7 +461,7 @@ protected StorageLocationReport.Builder reportBuilder() { StorageLocationReport.Builder builder = StorageLocationReport.newBuilder() .setFailed(isFailed()) .setId(getStorageID()) - .setStorageLocation(volumeRoot) + .setStorageLocation(storageDirStr) Review Comment: Please add a comment for field storageDirStr about the purpose. ########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/StorageVolume.java: ########## @@ -459,7 +461,7 @@ protected StorageLocationReport.Builder reportBuilder() { StorageLocationReport.Builder builder = StorageLocationReport.newBuilder() .setFailed(isFailed()) .setId(getStorageID()) - .setStorageLocation(volumeRoot) + .setStorageLocation(storageDirStr) Review Comment: Please add a comment for field storageDirStr about the motivation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org