szetszwo commented on code in PR #7109:
URL: https://github.com/apache/ozone/pull/7109#discussion_r2023799293
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -307,6 +307,14 @@ enum ReplicationFactor {
ZERO = 0; // Invalid Factor
}
+enum StorageType {
+ DISK_TYPE = 1;
+ SSD_TYPE = 2;
+ ARCHIVE_TYPE = 3;
+ RAM_DISK_TYPE = 4;
+ PROVIDED_TYPE = 5;
Review Comment:
I also don't recall.
> ... it was impossible to insert any new storage types in between. ...
Not really -- we may use 1.1 if there is a need.
Also, why it has to insert in between? We may put the new policy at the
end. I don't think Storage policy has a [total
ordering](https://en.wikipedia.org/wiki/Total_order).
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -307,6 +307,14 @@ enum ReplicationFactor {
ZERO = 0; // Invalid Factor
}
+enum StorageType {
+ DISK_TYPE = 1;
+ SSD_TYPE = 2;
+ ARCHIVE_TYPE = 3;
+ RAM_DISK_TYPE = 4;
+ PROVIDED_TYPE = 5;
Review Comment:
I also don't recall.
> ... it was impossible to insert any new storage types in between. ...
Not really -- we may use 1.1 if there is a need.
Also, why it has to insert in between? We may put the new policy at the
end. I don't think Storage policy has a [total
ordering](https://en.wikipedia.org/wiki/Total_order).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
