[
https://issues.apache.org/jira/browse/HDDS-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940794#comment-17940794
]
Tsz-wo Sze commented on HDDS-12750:
-----------------------------------
Updated the description.
bq. ... We should also rename ScmServerDatanodeHeartbeatProtocol.proto to
StorageContainerDatanodeProtocol.proto, i.e. make it consistent with its
java_outer_classname.
BTW, we have not done the rename due to
https://protobuf.dev/best-practices/1-1-1/
> Move StorageTypeProto from ScmServerDatanodeHeartbeatProtocol.proto to
> hdds.proto
> ---------------------------------------------------------------------------------
>
> Key: HDDS-12750
> URL: https://issues.apache.org/jira/browse/HDDS-12750
> Project: Apache Ozone
> Issue Type: Improvement
> Components: common
> Reporter: Tsz-wo Sze
> Assignee: Tsz-wo Sze
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.0.0
>
>
> TLDR: The change is wire compatible but requires updating protolock.
> In the PR of HDDS-11351, [~XiChen] pointed out that both hdds.proto and
> ScmServerDatanodeHeartbeatProtocol.proto have the same proto package
> "hadoop.hdds". So, we could safely move StorageTypeProto from
> ScmServerDatanodeHeartbeatProtocol.proto to hdds.proto. The only difference
> is the java_outer_classname. Fortunately,
> ScmServerDatanodeHeartbeatProtocol.proto is a non-user facing internal
> protocol and the change is wire compatible. (It is Java API incompatible but
> it is fine since the protocol is not a public API.) So there are no
> compatibility issues for ScmServerDatanodeHeartbeatProtocol.proto.
> For OzoneManagerProtocolProtos, it is visible from the StorageType class. So
> it is arguably a public API. This is Java API incompatible in this sense.
> -A problem is that we need to update the protolock file. We should also
> rename ScmServerDatanodeHeartbeatProtocol.proto to
> StorageContainerDatanodeProtocol.proto, i.e. make it consistent with its
> java_outer_classname.-
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
