szetszwo commented on code in PR #8192: URL: https://github.com/apache/ozone/pull/8192#discussion_r2027388935
########## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/lock/granular/OmLockManager.java: ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.om.lock.granular; + +import com.google.common.util.concurrent.StripedLock; +import com.google.common.util.concurrent.StripedReadWriteLocks; +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import org.apache.hadoop.ozone.om.lock.granular.OmComponentLock.Component; +import org.apache.hadoop.ozone.om.lock.granular.OmComponentLock.Type; +import org.apache.ratis.util.UncheckedAutoCloseable; + +/** + * Manage locking of volume, bucket and keys. + */ +public class OmLockManager { + private final StripedReadWriteLocks volumeLocks = StripedReadWriteLocks.newInstance(1 << 10, true); + private final StripedReadWriteLocks bucketLocks = StripedReadWriteLocks.newInstance(1 << 12, true); + private final StripedReadWriteLocks keyLocks = StripedReadWriteLocks.newInstance(1 << 16, true); + + static OmComponentLock newOmComponentLock(Component component, Type type, StripedLock<String> lock) { + return new OmComponentLock(lock.getStripeKey(), component, type, lock.getIndex(), lock.getLock()); + } + + private OmComponentLock newVolumeLock(Type type, String name) { + return newOmComponentLock(Component.VOLUME, type, volumeLocks.get(name)); + } + + private OmComponentLock newBucketLock(Type type, String name) { + return newOmComponentLock(Component.BUCKET, type, bucketLocks.get(name)); + } + + private OmComponentLock newKeyLock(Type type, String name) { + return newOmComponentLock(Component.KEY, type, keyLocks.get(name)); + } + + private List<OmComponentLock> newKeyLocks(Type type, List<String> names) { + final List<OmComponentLock> list = new ArrayList<>(); + for(StripedLock<String> lock : keyLocks.bulkGet(names)) { + list.add(newOmComponentLock(Component.KEY, type, lock)); + } + return Collections.unmodifiableList(list); + } + + private OmOperationLock newVolumeReadBucketWriteLock(String volume, String bucket) { + return OmOperationLock.newInstance( + newVolumeLock(Type.READ, volume), + newBucketLock(Type.WRITE, bucket)); Review Comment: I guess you prefer ```java OmOperationLock lock = OmOperationLock.newInstance(newVolumeLock(Type.READ, volume), newBucketLock(Type.WRITE, bucket)); ``` rather than ```java OmOperationLock lock = newVolumeReadBucketWriteLock(volume, bucket) ``` I am fine either way although the later is shorter. These are just private methods but not public APIs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
