siddhantsangwan commented on code in PR #8228:
URL: https://github.com/apache/ozone/pull/8228#discussion_r2028734554
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerData.java:
##########
@@ -226,6 +227,11 @@ public synchronized void setState(ContainerDataProto.State
state) {
}
}
+ @VisibleForTesting
+ void setCommittedSpace(boolean committedSpace) {
+ this.committedSpace = committedSpace;
+ }
+
Review Comment:
Thanks for the review @peterxcli. I think we should keep the annotation for
now, and remove it in the commit (your pr) where it's actually being used in
non-test code. That's because until the method is actually being used outside
of tests, it's only visible for testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
