szetszwo opened a new pull request, #8208: URL: https://github.com/apache/ozone/pull/8208
## What changes were proposed in this pull request? TLDR: The change is wire compatible but requires updating protolock. In the PR #7109 of HDDS-11351, @xichen01 pointed out that both hdds.proto and ScmServerDatanodeHeartbeatProtocol.proto have the same proto package "hadoop.hdds". So, we could safely move StorageTypeProto from ScmServerDatanodeHeartbeatProtocol.proto to hdds.proto. The only difference is the java_outer_classname. Fortunately, ScmServerDatanodeHeartbeatProtocol.proto is a non-user facing internal protocol and the change is wire compatible. (It is API incompatible but it is fine since the protocol is not a public API.) So there are no compatibility issues. A problem is that we need to update the protolock file. We should also rename ScmServerDatanodeHeartbeatProtocol.proto to StorageContainerDatanodeProtocol.proto, i.e. make it consistent with its java_outer_classname. ## What is the link to the Apache JIRA HDDS-12750 ## How was this patch tested? By existing test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
