Tejaskriya commented on code in PR #8112: URL: https://github.com/apache/ozone/pull/8112#discussion_r2005262318
########## hadoop-ozone/dist/src/main/smoketest/admincli/testdiskbalancer.robot: ########## @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +*** Settings *** +Documentation Smoketest ozone cluster startup +Library OperatingSystem +Resource ../commonlib.robot + +** Test Cases *** +Check failure with non-admin user to start, stop and update diskbalancer + Requires admin privilege ozone admin datanode diskbalancer start -a + Requires admin privilege ozone admin datanode diskbalancer stop -a + Requires admin privilege ozone admin datanode diskbalancer update -t 0.0002 -a + +Check success with admin user for start, stop and update diskbalancer + Run Keyword Kinit test user testuser testuser.keytab + ${result} = Execute and Ignore Error ozone admin datanode diskbalancer start -t 0.0002 -a Review Comment: nit: please align all the statements with the same indent ```suggestion Check success with admin user for start, stop and update diskbalancer Run Keyword Kinit test user testuser testuser.keytab ${result} = Execute and Ignore Error ozone admin datanode diskbalancer start -t 0.0002 -a ``` Same with all the other lines in this test and the next one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
