aswinshakil commented on code in PR #7474:
URL: https://github.com/apache/ozone/pull/7474#discussion_r2000642699
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java:
##########
@@ -600,28 +615,19 @@ ContainerCommandResponseProto handleCloseContainer(
return getSuccessResponse(request);
}
- private void createContainerMerkleTree(Container container) {
+ public ContainerProtos.ContainerChecksumInfo
createContainerMerkleTree(Container container) {
Review Comment:
Not sure why we would need `Optional` here when none of the method inside
`createContainerMerkleTree` returns `Optional`. Only `read` and `readBuilder`
returns `Optional` which are already handled by callers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
