adoroszlai commented on code in PR #7927:
URL: https://github.com/apache/ozone/pull/7927#discussion_r2002925236
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/fs/DedicatedDiskSpaceUsage.java:
##########
@@ -51,7 +51,7 @@ public long getUsedSpace() {
* @return used space
*/
private long calculateUsedSpace() {
- return getCapacity() - getFile().getFreeSpace();
+ return getCapacity() - getFile().getUsableSpace();
Review Comment:
For the record: javadoc on `calculateUsedSpace` still mentions "free space".
I guess we can update it in any patches touching this code, no need for a new
PR just for this.
Also: `getAvailble()` also returns `getUsableSpace()`, so we could clarify
the logic by changing to:
`getCapacity() - getAvailable()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
