xichen01 commented on PR #8008: URL: https://github.com/apache/ozone/pull/8008#issuecomment-2744128204
@szetszwo > Should we also shade META-INF/maven/org.reflections? I don't think it's necessary. Even in before jar, the content under META-INF/maven is not shaded. ```bash [root@bogon /tmp]% cat before_jar.txt | grep META-INF/maven | grep shade META-INF/maven/org.apache.ozone/ozone-filesystem-shaded/ META-INF/maven/org.apache.ozone/ozone-filesystem-shaded/pom.properties META-INF/maven/org.apache.ozone/ozone-filesystem-shaded/pom.xml [root@bogon /tmp]% ``` `META-INF/maven` seems to be just an archive file, it is not needed for runtime https://stackoverflow.com/questions/27382259/why-do-i-need-meta-inf-maven-dir-in-my-jar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
