adoroszlai commented on code in PR #8249: URL: https://github.com/apache/ozone/pull/8249#discussion_r2034535398
########## hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java: ########## @@ -416,7 +416,7 @@ public final class OzoneConfigKeys { public static final long HDDS_RATIS_SNAPSHOT_THRESHOLD_DEFAULT = ScmConfigKeys.HDDS_RATIS_SNAPSHOT_THRESHOLD_DEFAULT; public static final String HDDS_RATIS_LEADER_FIRST_ELECTION_MINIMUM_TIMEOUT_DURATION_KEY = - "hdds.ratis.leader.first.election.minimum.timeout.duration"; + "hdds.ratis.leader.first-election.minimum.timeout.duration"; Review Comment: I was [wondering](https://issues.apache.org/jira/browse/HDDS-12795?focusedCommentId=17941660&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17941660) the same. I would vote for removing them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org