priyeshkaratha commented on code in PR #8251:
URL: https://github.com/apache/ozone/pull/8251#discussion_r2037200941
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java:
##########
@@ -382,10 +411,14 @@ public List<ContainerWithPipeline>
getExistContainerWithPipelinesInBatch(
ContainerWithPipeline cp = getContainerWithPipelineCommon(containerID);
cpList.add(cp);
} catch (IOException ex) {
- //not found , just go ahead
- LOG.error("Container with common pipeline not found: {}", ex);
+ AUDIT.logReadFailure(buildAuditMessageForFailure(
+ SCMAction.GET_EXIST_CONTAINER_WITH_PIPELINE_BATCH,
+ Collections.singletonMap("containerID",
String.valueOf(containerID)), ex));
}
}
+ AUDIT.logReadSuccess(buildAuditMessageForSuccess(
+ SCMAction.GET_EXIST_CONTAINER_WITH_PIPELINE_BATCH,
+ Collections.singletonMap("containerIDs", containerIDs.toString())));
Review Comment:
here on IOException, its continue on loop for next entries and there are
chances for success and failures, so should I add list of ids that is success
into success audit logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
